X Tutup
Skip to content

feat(router): implement router link DSL#5562

Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:router_dsl
Closed

feat(router): implement router link DSL#5562
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:router_dsl

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Dec 3, 2015

/cc @btford

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 3, 2015
@vsavkin vsavkin added this to the beta.0 milestone Dec 3, 2015
@vsavkin vsavkin force-pushed the router_dsl branch 2 times, most recently from a5ef273 to 18ffe23 Compare December 3, 2015 00:48
@IgorMinar
Copy link
Copy Markdown
Contributor

  • use route: prefix instead of link:
  • add documentation

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 3, 2015
@IgorMinar IgorMinar assigned vsavkin and unassigned IgorMinar Dec 3, 2015
@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 4, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5562 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5562.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup