X Tutup
Skip to content

fix(forms): correct radio input functionality#5506

Closed
robwormald wants to merge 1 commit intoangular:masterfrom
robwormald:forms/radiocontrol
Closed

fix(forms): correct radio input functionality#5506
robwormald wants to merge 1 commit intoangular:masterfrom
robwormald:forms/radiocontrol

Conversation

@robwormald
Copy link
Copy Markdown
Contributor

Radio values use the "checked" property to denote state, and use
"value" property to write to model. Add separation between these two
values.

Fixes #5133, Fixes #3104

Radio values use the "checked" property to denote state, and use
"value" property to write to model. Add separation between these two
values.

Fixes angular#5133, Fixes angular#3104
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use providers

@IgorMinar
Copy link
Copy Markdown
Contributor

ci not happy.

I'm assigning this to @vsavkin since he's the most familiar with this part of the code base

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 2, 2015
@IgorMinar IgorMinar added this to the beta-01 milestone Dec 2, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

setting milestone beta.1. if we can get it in for 0 then great, otherwise it will be in beta.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use looseIdentical from lang.ts

@bradlygreen
Copy link
Copy Markdown
Contributor

@vsavkin can you get this in ASAP when you return? I'm hearing several folks in the wild stuck on this. Thanks!

@park9140
Copy link
Copy Markdown

👍 Just ran into this. Please fix :)

@rgrasso
Copy link
Copy Markdown

rgrasso commented Jan 29, 2016

👍 Still an issue in beta 1 would like to upvote this....

@maku
Copy link
Copy Markdown

maku commented Feb 1, 2016

Ran into this. Would be really urgent to fix this...

@vsavkin
Copy link
Copy Markdown
Contributor

vsavkin commented Feb 3, 2016

Replaced with #6877

@vsavkin vsavkin closed this Feb 3, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

input type=radio not updating form value input type=radio not handled correctly by ng-model

8 participants

X Tutup