feat(router): add support for APP_BASE_HREF to HashLocationStrategy#5451
Closed
btford wants to merge 1 commit intoangular:masterfrom
Closed
feat(router): add support for APP_BASE_HREF to HashLocationStrategy#5451btford wants to merge 1 commit intoangular:masterfrom
btford wants to merge 1 commit intoangular:masterfrom
Conversation
btford
added
the
action: review
Contributor
|
LGTM. The test code was really clear and well put together. Please fix the failing specs. |
Contributor
Author
|
🐈 will do! |
btford
force-pushed
the
feat-hash-location-support-app-base
branch
from
6692759 to
a00eee0
Compare
btford
added
action: cleanup
btford
force-pushed
the
feat-hash-location-support-app-base
branch
2 times, most recently
from
ec4ca4b to
b0f0baf
Compare
btford
force-pushed
the
feat-hash-location-support-app-base
branch
from
b0f0baf to
bd2e0e9
Compare
btford
added
action: merge
|
Merging PR #5451 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5451. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will need to go in once the issue with the refactor is resolved.
This also helps pave the way for #4943 by more cleanly refactoring out the platform-level URL parts from the routing parts.
@matsko could you review?
Closes #4935
Closes #5368