fix(http): error codes / headers / responseURL / request method#5397
Closed
robwormald wants to merge 4 commits intoangular:masterfrom
Closed
fix(http): error codes / headers / responseURL / request method#5397robwormald wants to merge 4 commits intoangular:masterfrom
robwormald wants to merge 4 commits intoangular:masterfrom
Conversation
robwormald
force-pushed
the
http-fixes
branch
from
cf338e8 to
086b712
Compare
robwormald
changed the title
Contributor
Author
|
@alxhub added another commit here, fyi |
robwormald
force-pushed
the
http-fixes
branch
2 times, most recently
from
89e95d1 to
1bf4d3e
Compare
robwormald
changed the title
robwormald
force-pushed
the
http-fixes
branch
2 times, most recently
from
ddf3c08 to
dfeccd3
Compare
robwormald
added
action: review
Contributor
|
I'll give this a look over |
BREAKING CHANGE: previously http would only error on network errors to match the fetch specification. Now status codes less than 200 and greater than 299 will cause Http's Observable to error. Closes angular#5130.
robwormald
force-pushed
the
http-fixes
branch
from
dfeccd3 to
d38f32c
Compare
Contributor
Author
|
fixed commit message formatting. |
Contributor
|
This is awesome! LGTM once you're happy with it, @robwormald |
jeffbcross
added
pr_state: LGTM
action: cleanup
robwormald
force-pushed
the
http-fixes
branch
2 times, most recently
from
ba85c61 to
b4a3c8f
Compare
Properly parse and add response Headers to Response. Closes angular#5237
Attach reponseURL or X-Request-URL to Response. Closes angular#5165
Honor method parameter passed to http.request(). Closes angular#5309
robwormald
force-pushed
the
http-fixes
branch
from
b4a3c8f to
c3034ea
Compare
robwormald
added
action: merge
|
Merging PR #5397 on behalf of @alxhub to branch presubmit-alxhub-pr-5397. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
previously http would only error on network errors to match the fetch
specification. Now status codes less than 200 and greater than 299 will
cause Http's Observable to error. Closes #5130.
Return Response Headers for Requests. Closes #5237
Return URL in Response. Closes #5165
Allow http.request(url, opts) to pass method. Closes #5309