chore(build): use Chromium in Travis for JS tests by marclaval · Pull Request #5393 · angular/angular

marclaval · 2015-11-19T22:38:45Z

No description provided.

marclaval · 2015-11-20T00:13:33Z

Chromium 37, it is not really recent version :/
/cc @IgorMinar

IgorMinar · 2015-11-20T02:20:03Z

Good start but why not download the most recent one and stick it into the
Travis cache?
On Thu, Nov 19, 2015 at 4:13 PM Marc Laval notifications@github.com wrote:

Chromium 37, it is not really recent version :/
/cc @IgorMinar https://github.com/IgorMinar

—
Reply to this email directly or view it on GitHub
#5393 (comment).

IgorMinar · 2015-12-02T18:06:24Z

ping? @Mlaval do you want to fix up this PR?

I think the intention of the change is good.

jeffbcross · 2016-02-01T23:19:00Z

Closing until @Mlaval decides he's interested in this PR again :)

marclaval · 2016-02-02T18:11:50Z

I forgot this PR. It was ready for review but clearly lacks some explanations.

IgorMinar · 2016-02-02T18:16:24Z

We should make sure that this PR also fixes #6846.

@Mlaval could you please refresh this PR and address the comments I mentioned above? thanks!

marclaval · 2016-02-03T14:55:56Z

All good, the latest stable Chromium for Linux is now downloaded and cached.
It is used to run all JS tests. It should solve #6846 as E2E_BROWSERS is also used there.
@IgorMinar would you mind reviewing this PR please?

Some additional information about how the new install_chromium script, which basically follows the instructions to download an old version of Chromium: https://www.chromium.org/getting-involved/download-chromium

It retrieves the current stable version number from https://www.chromium.org/developers/calendar (via the https://omahaproxy.appspot.com/all file), e.g. 359700 for Chromium 48.
It checks the Travis cache for this specific version
If not available, it downloads and caches it, using the "decrement commit number" trick.

IgorMinar · 2016-02-08T21:26:19Z

scripts/ci/install_chromium.sh

can you use trap to reliably restore the variable in case one of the above commands fail?

IgorMinar · 2016-02-08T21:30:28Z

the rest looks good

IgorMinar · 2016-02-08T22:16:03Z

@Mlaval can you also please add the description from #5393 (comment) into the install_chromium.sh bash?

IgorMinar · 2016-02-08T22:47:35Z

.travis.yml

oh. I see!!! sorry. I missed this line. please ignore all of my comments about caching.

marclaval · 2016-02-10T16:13:54Z

Comments added where needed.

To get the build number of the latest stable, I didn't use trap but made this part safe. If something goes wrong (404, bad content returned), CHROMIUM_VERSION will correctly defaults to 352221.

yjbanov · 2016-02-21T07:11:54Z

Any ETA on landing this? It is blocking #6783

vsavkin · 2016-03-01T20:46:24Z

Merged via 391a9ed

yjbanov · 2016-03-01T21:29:00Z

@vsavkin: Thanks a bunch!

angular-automatic-lock-bot · 2019-09-13T00:51:29Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Nov 19, 2015

marclaval force-pushed the chromeInTravis branch from e4c911d to 5989206 Compare November 19, 2015 22:56

IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 2, 2015

IgorMinar assigned IgorMinar and marclaval and unassigned IgorMinar Dec 2, 2015

IgorMinar added this to the beta.0 milestone Dec 2, 2015

marclaval force-pushed the chromeInTravis branch 5 times, most recently from 8a7d037 to 29b7970 Compare December 15, 2015 17:37

marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 15, 2015

marclaval assigned IgorMinar and unassigned marclaval Dec 15, 2015

IgorMinar modified the milestone: beta.0 Dec 15, 2015

jeffbcross closed this Feb 1, 2016

marclaval reopened this Feb 2, 2016

marclaval force-pushed the chromeInTravis branch from 29b7970 to 77430ae Compare February 2, 2016 18:12

IgorMinar mentioned this pull request Feb 2, 2016

Run travis browser tests on Chrome >= stable #6846

Closed

mhevery added the hotlist: DDC label Feb 2, 2016

marclaval force-pushed the chromeInTravis branch from 77430ae to e04d27c Compare February 2, 2016 21:59

IgorMinar reviewed Feb 8, 2016
View reviewed changes

IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 8, 2016

IgorMinar assigned marclaval and unassigned IgorMinar Feb 8, 2016

IgorMinar reviewed Feb 8, 2016
View reviewed changes

.travis.yml Outdated

Copy link
Copy Markdown

Contributor

IgorMinar Feb 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. I see!!! sorry. I missed this line. please ignore all of my comments about caching.

chore(build): use Chromium in Travis for JS tests

09ce4d6

marclaval force-pushed the chromeInTravis branch from ba2b428 to 09ce4d6 Compare February 10, 2016 15:24

marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 10, 2016

marclaval assigned IgorMinar and unassigned marclaval Feb 10, 2016

IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Feb 11, 2016

yjbanov mentioned this pull request Feb 12, 2016

chore(ddc): add e2e test infra + first test #6783

Closed

yjbanov removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 19, 2016

vsavkin added the zomg_admin: do merge label Feb 25, 2016

vsavkin closed this Mar 1, 2016

marclaval deleted the chromeInTravis branch December 11, 2017 10:10

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

marclaval commented Nov 19, 2015

Uh oh!

marclaval commented Nov 20, 2015

Uh oh!

IgorMinar commented Nov 20, 2015

Uh oh!

IgorMinar commented Dec 2, 2015

Uh oh!

jeffbcross commented Feb 1, 2016

Uh oh!

marclaval commented Feb 2, 2016

Uh oh!

IgorMinar commented Feb 2, 2016

Uh oh!

marclaval commented Feb 3, 2016

Uh oh!

IgorMinar Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

marclaval Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

IgorMinar commented Feb 8, 2016

Uh oh!

IgorMinar commented Feb 8, 2016

Uh oh!

IgorMinar Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

marclaval commented Feb 10, 2016

Uh oh!

yjbanov commented Feb 21, 2016

Uh oh!

vsavkin commented Mar 1, 2016

Uh oh!

yjbanov commented Mar 1, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants