Style nitpick: We don't really need the custom negativeCompare here. Instead I'd do:

    toHaveCssStyle: function() {
      return {compare: {
        return function(actual, styles) {
          var allPassed;
          if (isString(styles)) {
            allPassed = DOM.hasStyle(actual, styles);
          } else {
            allPassed = !StringMapWrapper.isEmpty(styles);
            StringMapWrapper.forEach(styles, (style, prop) => {
              allPassed = allPassed && DOM.hasStyle(actual, prop, style);
            });
          }

          return {
            pass: allPassed,
            get message() {
              var expectedValueStr = isString(styles) ? styles : JSON.stringify(styles);
              return `Expected ${actual.outerHTML} ${!allPassed ? 'not ' : ''} to contain the
                      CSS ${isString(styles) ? 'property' : 'styles'} "${expectedValueStr}"`;
            }
          };
        };
      }
    },

This makes sense up to the point where we use !allPassed to turn on the "not " token within the error message. That doesn't look right.

It's the recommended way in the Jasmine docs though - if it didn't pass but we're throwing an error, we know the check was with a .not.

True. OK. I've updated the changes and force pushed.

CI still not happy
On Fri, Nov 20, 2015 at 9:50 AM Matias Niemelä notifications@github.com
wrote:

In modules/angular2/src/testing/matchers.ts
#5371 (comment):

@@ -105,6 +107,33 @@ _global.beforeEach(function() {
}
},

• toHaveCssStyle: function() {

•  return {compare: buildError(false), negativeCompare: buildError(true)};
  

True. OK. I've updated the changes and force pushed.

—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/5371/files#r45496685.

I think it should be the other way around: !allPassed ? '' : 'not'

Pretty minor, but ' ' should be '' to avoid excess whitespace.