cleanup(core): stop reexporting angular2/common from angular2/core#5362
Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
Closed
cleanup(core): stop reexporting angular2/common from angular2/core#5362vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin wants to merge 1 commit intoangular:masterfrom
Conversation
vsavkin
added
the
action: review
IgorMinar
added
pr_state: LGTM
action: cleanup
All common directives, forms, and pipes have been moved out of angular2/core,
but we kept reexporting them to make transition easier.
This commit removes the reexports.
BREAKING CHANGE
Before
import {NgIf} from 'angular2/core';
After
import {NgIf} from 'angular2/common';
vsavkin
force-pushed
the
do_not_reexport_common_from_core
branch
from
99607d9 to
021fbb4
Compare
vsavkin
added
action: merge
|
Merging PR #5362 on behalf of @alxhub to branch presubmit-alxhub-pr-5362. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All common directives, forms, and pipes have been moved out of angular2/core,
but we kept reexporting them to make transition easier.
This commit removes the reexports.
BREAKING CHANGE
Before
import {NgIf} from 'angular2/core';
After
import {NgIf} from 'angular2/common';
This PR also cleans up imports, so angular2/common does not reach into the internals of angular2/core.