refactor(angular_1_router): Angular 1.X component integration#5277
Closed
coutin wants to merge 1 commit intoangular:masterfrom
coutin:compenent-for-1.x-new-router
Closed
refactor(angular_1_router): Angular 1.X component integration#5277coutin wants to merge 1 commit intoangular:masterfrom coutin:compenent-for-1.x-new-router
coutin wants to merge 1 commit intoangular:masterfrom
coutin:compenent-for-1.x-new-router
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest update on angular 1.5, @shahata introduced a more convenient way to create component (Through this PR angular/angular.js#12933). The thing is the default configuration of the components prevent the new router to use it as is.
The default value of the restrict is 'E' whereas the ngOutlet directive is expecting components with a restrict 'A'
This PR is just simple modification of the ngOutlet directive to make the default configuration of a component working with the new router.