X Tutup
Skip to content

Case sensitive html parser#5264

Closed
vicb wants to merge 2 commits intoangular:masterfrom
vicb:htmlparser
Closed

Case sensitive html parser#5264
vicb wants to merge 2 commits intoangular:masterfrom
vicb:htmlparser

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Nov 12, 2015

No description provided.

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove todo
by purpose not complete....

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Nov 12, 2015

Reviewed in person with @tbosch

@vicb vicb force-pushed the htmlparser branch 5 times, most recently from b226eb0 to a4bc42e Compare November 13, 2015 00:27
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Nov 13, 2015

TODO: ref #4417

@vicb vicb changed the title WIP Htmlparser Case sensitive html parser Nov 13, 2015
@vicb vicb force-pushed the htmlparser branch 2 times, most recently from 92f4b08 to 61ac285 Compare November 13, 2015 21:24
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Nov 13, 2015

Error messages: take previous and following 2 lines, instead of -1- and +10 chars

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Nov 13, 2015

Entities: lt, gt, nbsp

@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5264 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5264.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 16, 2015
@vicb vicb closed this in a8edc1e Nov 16, 2015
@vicb vicb reopened this Nov 16, 2015
@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Nov 18, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5264 on behalf of @alxhub to branch presubmit-alxhub-pr-5264.

@vicb vicb closed this in 36a423f Nov 19, 2015
@vicb vicb deleted the htmlparser branch June 23, 2016 17:45
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: no

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

X Tutup