Reviewed in person with @vsavkin

/cc @vsavkin: Could you merge this?

Merging PR #5227 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5227.

Merging PR #5227 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5227.

Use comments does not work with AppView.logBindingUpdate.

FYI I am planning to work on this after landing #5036, which hopefully will be done today (work is done, just updating docs now and then need to submit PR). The time risk of that issue depends mostly on how difficult it is to merge into google3.

Back to work on this issue now...

To recap the approach I've just discussed with @tbosch, for my own memory:

I'm going to implement a new Renderer method called setBindingDebugInfo that will be called by AppView.prototype.logBindingUpdate. The setBindingDebugInfo method will check if the element is a comment, try to extract a JSON object containing its bindings. Then the updated bindings will be serialized back to the comment as a JSON object: <!--template bindings={"property":"value"}-->

To support this, when the template comment is initially created, it will contain an empty bindings object: <!--template bindings={}-->

The setBindingDebugInfo method in the web worker renderer will serialize the inputs and tell the main thread to execute setBindingDebugInfo.

We decided on implementing the new method so we can not negatively impact the performance of the setElementAttribute method that is currently being called by logBindingInfoUpdate, since the use case of updating binding info is only for dev mode.

Sorry for bumping. The changelog for alpha 47 shows that this was closed in this commit bb9cfe6, but I still can see script tags in the DOM
Repro with a47
http://plnkr.co/edit/M37R7sk1tI3mwwrGgLo4?p=preview

Is that an error in the changelog?

Oops that is a problem with our change log script not knowing when a commit
has been reverted. The change had been merged and reverted so is currently
still pending.
On Tue, Dec 1, 2015 at 2:04 PM ericmartinezr notifications@github.com
wrote:

Sorry for bumping. The changelog for alpha 47 shows that this was closed
in this commit bb9cfe6 bb9cfe6,
but I still can see script tags in the DOM
Repro with a47
http://plnkr.co/edit/M37R7sk1tI3mwwrGgLo4?p=preview

Is that an error in the changelog?

—
Reply to this email directly or view it on GitHub
#5227 (comment).

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}