X Tutup
Skip to content

chore(bundles): publish UMD bundles#5149

Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:umd_with_webpack
Closed

chore(bundles): publish UMD bundles#5149
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:umd_with_webpack

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 5, 2015

So, this is a PR that adds UMD bundles for core, router and http. RxJS is an external dependency here.

Now, even if those bundles make it possible to use CJS-based tools / workflows (WebPack and company) there are far from ideal:

  • we can't bundle external deps (zone, reflect-metadata, RxJS)
  • assuming that a person uses core + http + router we got bundles that are bigger as compared to System.register ones (well, currently it is even worst due to refactor(router): don't import public APIs from internal paths #5139)
  • I believe that the resulting CJS-based workflow experience is actually worse as compared to bundling ng2

Given all those issues I'm more and more skeptical when it comes to value of those bundles. I've been debating this topic with @IgorMinar, @rkirov, @robwormald an many others and IMO it would make sense to bring this topic during one of the next team meetings.

Anyway, PR / bundles are here.

@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 9, 2015
@pkozlowski-opensource pkozlowski-opensource added this to the beta-00 milestone Nov 9, 2015
@pkozlowski-opensource pkozlowski-opensource force-pushed the umd_with_webpack branch 2 times, most recently from 475c068 to 0e6c950 Compare November 9, 2015 19:54
@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Nov 9, 2015

We're going to discuss this PR over VC on Tuesday 11/10 at 11am PDT. @robwormald, @vsavkin, @rkirov if any of you would like to join, lmk.

@robwormald
Copy link
Copy Markdown
Contributor

robwormald commented Nov 9, 2015

Yes plz

On Nov 9, 2015, at 2:43 PM, Jeff Cross notifications@github.com wrote:

We're going to discuss this PR over VC on Tuesday 11/10 at 11am PDT. @robwormald https://github.com/robwormald, @vsavkin https://github.com/vsavkin if either of you would like to join, lmk.

—
Reply to this email directly or view it on GitHub #5149 (comment).

@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Nov 10, 2015

Here is the follow-up proposal from @pkozlowski-opensource based on our call:

  • Single mega sfx/umd bundle that includes core, http, router, reflect-metadata, zone, rxjs.
  • Core bundle that only includes core stuff. So if users want to use HTTP or Router with a bundle, they need to use the mega bundle.
  • No other bundles. Encourage build tools based on our published files (ts, es6, or es5/CJS)

Pawel is going to open new issues describing the new approach.

@jeffbcross jeffbcross closed this Nov 10, 2015
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Nov 10, 2015
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jeffbcross jeffbcross

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

beta.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pkozlowski-opensource @jeffbcross @robwormald @googlebot
X Tutup