fix(RouterLink): do not prevent default behavior if target set on anc…#5082
Closed
jeffbcross wants to merge 1 commit intoangular:masterfrom
Closed
fix(RouterLink): do not prevent default behavior if target set on anc…#5082jeffbcross wants to merge 1 commit intoangular:masterfrom
jeffbcross wants to merge 1 commit intoangular:masterfrom
Conversation
jeffbcross
added
comp: router
action: review
Contributor
Author
|
I forgot that we don't have the reverse-lookup enum support enabled in ts2dart :/. dart-archive/ts2dart#221 |
Contributor
Author
|
I'll update this not to use enums. |
Contributor
|
Other than the enum thing, LGTM. Merge once that fix is in 👍 |
jeffbcross
force-pushed
the
router-target
branch
from
fd7f720 to
a532ab8
Compare
Contributor
Author
|
(I got verbal LGTM of recent changes from @btford) |
|
Merging PR #5082 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-5082. |
Contributor
|
(confirming said verbal LGTM, also thanks for your work on this, @jeffbcross ) |
…hor element If the anchor element on which the "router-link" directive is present has a target attribute other than "_self," the handler will not prevent default behavior of the browser. Closes angular#4233
jeffbcross
force-pushed
the
router-target
branch
from
a532ab8 to
0f12a6f
Compare
|
Merging PR #5082 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-5082. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hor element
If the anchor element on which the "router-link" directive is present has a target
attribute other than "_self," the handler will not prevent default behavior of
the browser.
Closes #4233