X Tutup
Skip to content

Bypass unnecessary top level actions in local compilation mode #50486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmvald wants to merge 2 commits into from
Closed

Bypass unnecessary top level actions in local compilation mode #50486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c594d59
refactor(bazel): Circuit out ts semantic check in local mode compilation
pmvald May 26, 2023
9fde611
refactor(compiler-cli): Remove .d.ts files transformer in local compi…
pmvald May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/bazel/src/ngc-wrapped/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,13 @@ function gatherDiagnosticsForInputsOnly(
// Note: We only get the diagnostics for individual files
// to e.g. not check libraries.
diagnostics.push(...tsProgram.getSyntacticDiagnostics(sf));
diagnostics.push(...tsProgram.getSemanticDiagnostics(sf));

// In local mode compilation the TS semantic check issues tons of diagnostics due to the fact
// that the file dependencies (.d.ts files) are not available in the program. So it needs to be
// disabled.
if (options.compilationMode !== 'experimental-local') {
diagnostics.push(...tsProgram.getSemanticDiagnostics(sf));
}
}

if (ngProgram instanceof ng.NgtscProgram) {
Expand Down
6 changes: 5 additions & 1 deletion packages/compiler-cli/src/ngtsc/core/src/compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,11 @@ export class NgCompiler {
];

const afterDeclarations: ts.TransformerFactory<ts.SourceFile>[] = [];
if (compilation.dtsTransforms !== null) {

// In local compilation mode we don't make use of .d.ts files for Angular compilation, so their
// transformation can be ditched.
if (this.options.compilationMode !== 'experimental-local' &&
compilation.dtsTransforms !== null) {
afterDeclarations.push(declarationTransformFactory(
compilation.dtsTransforms, compilation.reflector, compilation.refEmitter,
importRewriter));
Expand Down
X Tutup