chore(http): fix Http Response type#5017
Conversation
0139b6c to
6891cd4
Compare
|
@pkozlowski-opensource this should also prevent Rx from being double-built into the bundles |
There was a problem hiding this comment.
This should be split into a separate commit (same PR)
|
The commit message should be |
|
Looks good with cleanup! |
00559f1 to
48a80d6
Compare
Return Response when JSONP backend errors
48a80d6 to
48287fb
Compare
|
this surfaced an issue with RxJS typings on operators : ReactiveX/rxjs#635 - investigating. Means that this works fine: http.get('/foo').subscribe(res => console.log(res.json());but this complains: http.get('/foo')
.map(res => res.json()) //error: res (any) does not have property .json()
.subscribe(foos => console.log(foos));temporary workaround is to cast to response: http.get('/foo')
.map((res:Response) => res.json()) //ok
.subscribe(foos => console.log(foos))which kind of defeats the purpose 😿 |
use correct type definitions for Http responses.
48287fb to
db40f9a
Compare
|
@jeffbcross issues addressed, reordered the commits. issue above is non-blocking I think, so lets merge to get @pkozlowski-opensource unblocked on bundle stuff. give this a once over if you would. |
|
Merging PR #5017 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-5017. |
|
@robwormald merging! |
|
Yay! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
use Observable for Http responses