Analytics add npm install + ci tracking#4955
Analytics add npm install + ci tracking#4955IgorMinar wants to merge 4 commits intoangular:masterfrom
Conversation
IgorMinar
force-pushed
the
analytics-npm-install
branch
2 times, most recently
from
fff1f9d to
09834e5
Compare
|
@alexeagle what do you think about this approach? I track all start events as well as all end events, but for end events I also track duration. |
IgorMinar
changed the title
package.json
Outdated
There was a problem hiding this comment.
can we move this to a .sh file? it's getting out of control
There was a problem hiding this comment.
I'd love to but that would make the scripts platform specific. the current approach is the only way to make this work across all platforms.
There was a problem hiding this comment.
I figured as much. Here is another idea:
"scripts": {
"test": "npm run test1 && npm run test2",
"test1": "echo test1",
"test2": "echo test2"
},
I tried that out and it appears to work fine. The scripts here will still be long but at least we could split into a few bits, maybe:
"postinstall": "node tools/analytics/build-analytics finish install npm-install-net; node tools/analytics/build-analytics start install npm-postinstall; npm run setup-env; npm run install-typings; node tools/analytics/build-analytics finish install npm-postinstall; node tools/analytics/build-analytics finish install npm-install",
It would also help with the nesting of the analytics instrumentation. Parent-level timespans can be in the 'master' command and children timespans go in the sub-commands
|
Can you add me to the analytics account to see what we're gathering already? |
|
Nice, I'm sure we can do something with this data, even though it's hard to make Analytics UI show us what we need to know |
IgorMinar
force-pushed
the
analytics-npm-install
branch
2 times, most recently
from
a70b8eb to
4165b9d
Compare
Since the very first npm install is called while node_modules is empty, we need to ignore it, but we can track the start timestamp and record the install even once the installation is completed.
VSCode recognizes jsconfig.json for es6 code in the same way as it recognizes tsconfig.json for ts code.
|
Merging PR #4955 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4955. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
No description provided.