Support RootRouter.dispose() and register it to automatically clean up the RootRouter when the application is disposed#4915
Closed
alxhub wants to merge 3 commits intoangular:masterfrom
Closed
Conversation
alxhub
added
cla: no
action: review
mhevery
added
pr_state: LGTM
and removed
action: review
alxhub
force-pushed
the
router-disposable
branch
5 times, most recently
from
c84895f to
77b5a4b
Compare
…sposal functions. These functions will be called whenever the platform or application are being disposed.
… subscription. ROUTER_PROVIDERS now automatically disposes of the RootRouter when the application is disposed.
alxhub
force-pushed
the
router-disposable
branch
from
77b5a4b to
f0ac49b
Compare
mary-poppins
removed
the
action: merge
|
Merging PR #4915 on behalf of @alxhub to branch presubmit-alxhub-pr-4915. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.