docs(developer.md): add PUB_CACHE variable to setup instructions#4900
Closed
Puigcerber wants to merge 1 commit intoangular:masterfrom
Closed
docs(developer.md): add PUB_CACHE variable to setup instructions#4900Puigcerber wants to merge 1 commit intoangular:masterfrom
Puigcerber wants to merge 1 commit intoangular:masterfrom
Conversation
If PUB_CACHE is not set the pub dependencies are downloaded to a default folder during the build because `gulp build` also runs `pub get`. Running the tests locally PUB_CACHE is set to a subdirectory of the SDK when the `env_dart.sh` script is sourced. Therefore `build/pubbuild.dart` fails as it can't find the dependencies.
mhevery
added
pr_state: LGTM
action: merge
|
Merging PR #4900 on behalf of @mhevery to branch presubmit-mhevery-pr-4900. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If PUB_CACHE is not set the pub dependencies are downloaded to a default
folder during the build because
gulp buildalso runspub get.Running the tests locally PUB_CACHE is set to a subdirectory of the SDK
when the
env_dart.shscript is sourced.Therefore
build/pubbuild.dartfails as it can't find the dependencies.