fix(test_lib): don't mock out XHR via MockXHR by default in tests#4682
Closed
IgorMinar wants to merge 1 commit intoangular:masterfrom
Closed
fix(test_lib): don't mock out XHR via MockXHR by default in tests#4682IgorMinar wants to merge 1 commit intoangular:masterfrom
IgorMinar wants to merge 1 commit intoangular:masterfrom
Conversation
IgorMinar
added
the
action: review
tbosch
added
pr_state: LGTM
action: cleanup
This is useful for the compiler tests, but otherwise it's not useful. Additionally if an application has external templates (as is common) then we should actually fetch these templates in tests. Fixes angular#4539
IgorMinar
force-pushed
the
fix-test-injector-xhr
branch
from
96de3a4 to
6355c5b
Compare
|
Merging PR #4682 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4682. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for the compiler tests, but otherwise it's not useful.
Additionally if an application has external templates (as is common) then
we should actually fetch these templates in tests.
Fixes #4539