X Tutup
Skip to content

refactor(ng2_transform): use the latest version of pkg/protobuf#4681

Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:latest_protobuf
Closed

refactor(ng2_transform): use the latest version of pkg/protobuf#4681
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:latest_protobuf

Conversation

@kegluneq
Copy link
Copy Markdown

Closes #4644

@kegluneq kegluneq added comp: dart-transformer action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 12, 2015
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Oct 12, 2015

@kegluneq how is this different than my CL?

@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Oct 12, 2015

LGTM

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Update
- libprotoc to 2.6.1
- dart-protoc-plugin to 0.5.0
- pkg/protobuf 0.5.0

Closes angular#4681
@kegluneq kegluneq added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 12, 2015
@kegluneq
Copy link
Copy Markdown
Author

(Added label for kevmoo@)

@kegluneq kegluneq assigned kegluneq and unassigned kevmoo Oct 12, 2015
@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Oct 14, 2015

@kegluneq this will get auto-magic merged, right?

@kegluneq
Copy link
Copy Markdown
Author

No, not without the merge label.

I'm waiting for the next cut before submitting this, as I don't want protobuf changes to cause issues there.

@kegluneq kegluneq closed this in cf9d466 Oct 19, 2015
@kegluneq kegluneq deleted the latest_protobuf branch October 19, 2015 18:13
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Dart transformers pkg to use protobuf 0.5

3 participants

X Tutup