X Tutup
Skip to content

build(analytics): add basic build-analytics to the project#4672

Closed
IgorMinar wants to merge 1 commit intoangular:masterfrom
IgorMinar:build-analytics
Closed

build(analytics): add basic build-analytics to the project#4672
IgorMinar wants to merge 1 commit intoangular:masterfrom
IgorMinar:build-analytics

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar commented Oct 11, 2015

This is pretty experimental, but the goal is to track the performance
of our build over time so that we can more easily track perf regressions.

Currently it's integrated only with gulp tasks, but I'd like to expand it
to tracking travis jobs, protractor/benchpress test runs, npm installs, etc.

No PII is being collected. And the data is collected via a Google Analytics
property owned by the Angular team account.

@IgorMinar IgorMinar force-pushed the build-analytics branch 2 times, most recently from 078316a to a5a7113 Compare October 11, 2015 22:31
@alexeagle
Copy link
Copy Markdown
Contributor

alexeagle commented Oct 12, 2015

Interesting approach.
@ruleant - any experience with this way to gather build trends?

alexeagle
alexeagle reviewed Oct 12, 2015
View reviewed changes
gulpfile.js
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle Oct 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what the analytics look like if the end event never happens

Copy link
Copy Markdown
Contributor Author

@IgorMinar IgorMinar Oct 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there would be no event. I'm not tracking the beginning, just the completion (or error).

@IgorMinar IgorMinar force-pushed the build-analytics branch 2 times, most recently from 57d5184 to a04f056 Compare October 12, 2015 03:45
@IgorMinar
build(analytics): add basic build-analytics to the project
6ad1185 
This is pretty experimental, but the goal is to track the performance
of our build over time so that we can more easily track perf regressions.

Currently it's integrated only with gulp tasks, but I'd like to expand it
to tracking travis jobs, protractor/benchpress test runs, npm installs, etc.

No PII is being collected. And the data is collected via a Google Analytics
property owned by the Angular team account.
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 12, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 12, 2015

Merging PR #4672 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4672.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 12, 2015
@IgorMinar IgorMinar assigned IgorMinar and unassigned alexeagle Oct 12, 2015
@IgorMinar IgorMinar closed this in da1272f Oct 12, 2015
@ruleant
Copy link
Copy Markdown

ruleant commented Nov 20, 2015

HI Alex,

Interesting. I like it is using Google analytics to gather data and
visualise it. What does the dashboard look like?

I have a few remarks about this approach :

  • It doesn't seem to track build job duration (maybe I missed it), which is
    probably hard to do accurately when running inside the build job it is
    monitoring.
  • The analytics is part of the build script, so it can't easily be reused
    in other projects, or ported to another language. In my project I chose to
    build a service that gets most data from the Travis CI logfile and the
    Travis CI API, which makes it language agnostic and easy to start using for
    any build on Travis CI.

The script is a nice approach to log internal/custom data, which could be
picked up by another build monitoring tool that aggregates all available
info about a build job.

Kind regards,

Dieter
Developer https://github.com/buildtimetrend

2015-10-12 4:44 GMT+02:00 Alex Eagle notifications@github.com:

Interesting approach.
@ruleant https://github.com/ruleant - any experience with this way to
gather build trends?

—
Reply to this email directly or view it on GitHub
#4672 (comment).

Kind regards,

Dieter Adriaenssens

@IgorMinar
Copy link
Copy Markdown
Contributor Author

IgorMinar commented Nov 21, 2015

Yes, there are trade offs.

We do monitor duration and report it to GA. We measure duration for
individual job segments as well as for the job overall.

I don't know what will be the best approach long term, but it's worth to
try this.

One interesting thing that we can see via GA but not via logs is how long
did it take for Travis to pick up a build from the queue. This can be done
via combination of github web hooks and in-job reporting.

On Fri, Nov 20, 2015 at 9:28 AM Dieter Adriaenssens <
notifications@github.com> wrote:

HI Alex,

Interesting. I like it is using Google analytics to gather data and
visualise it. What does the dashboard look like?

I have a few remarks about this approach :

  • It doesn't seem to track build job duration (maybe I missed it), which is
    probably hard to do accurately when running inside the build job it is
    monitoring.
  • The analytics is part of the build script, so it can't easily be reused
    in other projects, or ported to another language. In my project I chose to
    build a service that gets most data from the Travis CI logfile and the
    Travis CI API, which makes it language agnostic and easy to start using for
    any build on Travis CI.

The script is a nice approach to log internal/custom data, which could be
picked up by another build monitoring tool that aggregates all available
info about a build job.

Kind regards,

Dieter
Developer https://github.com/buildtimetrend

2015-10-12 4:44 GMT+02:00 Alex Eagle notifications@github.com:

Interesting approach.
@ruleant https://github.com/ruleant - any experience with this way to
gather build trends?

—
Reply to this email directly or view it on GitHub
#4672 (comment).

Kind regards,

Dieter Adriaenssens

—
Reply to this email directly or view it on GitHub
#4672 (comment).

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@IgorMinar IgorMinar

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IgorMinar @alexeagle @mary-poppins @ruleant @googlebot
X Tutup