there are references in the gulp file, and also in dart_tree.ts, browser_tree.ts and node_tree.ts

can you fix that please and rebase?

@IgorMinar Done, I just rebased and left one single commit. I couldn't find the references you mention in the node_tree.ts file, the rest are just fine. Give some feedback when you have time 😉

@kutyel looks better, but there are still conflicts. can you rebase one more time please?

@IgorMinar Done, thanks for the assistance 😄

Sorry, there are still some test failures. looks like you missed a rename somewhere that is affecting e2e tests. Can you please look into it (and rebase against master again + squash everything into one commit).

Lastly, please change the commit message to:

chore: rename modules/examples to modules/playground

The directory contains code authored in a style that makes it transpilable to dart. As such, these are not idiomatic examples of Angular 2 usage.

The main purpose of this directory is to enable experimentation with Angular within the angular/angular repository.

Closes #4342

Thanks

I think this is the last instance of "example" that needs to be updated: https://github.com/kutyel/angular/blob/ffaa1a2164aa21c9b7499c36222ea1b260ca6a8a/tools/broccoli/html-replace/SCRIPTS_benchmarks.html#L10

sorry, I know that this is back and forth frustrating..

@IgorMinar I finally made it! Don't worry, putting aside the initial frustration, I'm very happy to contribute to such an awesome project! 😄

Merging PR #4639 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4639.

Merged! Thanks!

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}