chore(test): make e2e tests use the bundles.#4565
Closed
rkirov wants to merge 1 commit intoangular:masterfrom
Closed
chore(test): make e2e tests use the bundles.#4565rkirov wants to merge 1 commit intoangular:masterfrom
rkirov wants to merge 1 commit intoangular:masterfrom
Conversation
After this change, only web_worker thread in its e2e test is not using the bundles.
Contributor
There was a problem hiding this comment.
is this intentional? looks like a formatting error
Contributor
Author
There was a problem hiding this comment.
hmm, that's what clang-format did and it does pass the format check. The previous code definitely didn't go through clang-format as it has function () instead of function().
IgorMinar
added
pr_state: LGTM
action: merge
|
Merging PR #4565 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4565. |
1 similar comment
|
Merging PR #4565 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4565. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, only web_worker thread in its e2e test is not using
the bundles.