docs(router): Document PathLocationStrategy as default#4517
Closed
brandonroberts wants to merge 1 commit intoangular:masterfrom
Closed
docs(router): Document PathLocationStrategy as default#4517brandonroberts wants to merge 1 commit intoangular:masterfrom
brandonroberts wants to merge 1 commit intoangular:masterfrom
Conversation
brandonroberts
force-pushed
the
router-default-location-strategy
branch
from
ff79ca3 to
b2141ec
Compare
Contributor
|
Oh jeez– I totally got this backwards. I think the docs should be updated instead. Would be happy to get a PR doing that, @brandonroberts! Feel free to just force-push to this PR, no need to create a new one |
brandonroberts
force-pushed
the
router-default-location-strategy
branch
2 times, most recently
from
d2e6c94 to
c6379c7
Compare
Contributor
Author
|
Sure. PR has been updated with docs fix @btford |
brandonroberts
changed the title
brandonroberts
force-pushed
the
router-default-location-strategy
branch
from
c6379c7 to
c24c153
Compare
Contributor
|
Looks good to me– thanks @brandonroberts! |
|
Merging PR #4517 on behalf of @btford to branch presubmit-btford-pr-4517. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the default location strategy used by the ROUTER_BINDINGS and routerBindings exports to match the default as stated in the HashLocationStrategy documentation.