X Tutup
Skip to content

chore: remove devDependencies from package.json published to npm#4502

Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:remove_es5_build
Closed

chore: remove devDependencies from package.json published to npm#4502
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource:remove_es5_build

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

@pkozlowski-opensource pkozlowski-opensource commented Oct 3, 2015

This is a follow up PR related to #4454 - since we are dropping es6 output and all the convenience script to transpile e6->es5 we don't need devDependencies in the published npm package

@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Oct 3, 2015
Closed
@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

pkozlowski-opensource commented Oct 3, 2015

@alexeagle @IgorMinar could you please take a look?

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 3, 2015

Merging PR #4502 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4502.

1 similar comment
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 3, 2015

Merging PR #4502 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4502.

@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Oct 3, 2015
@mary-poppins mary-poppins removed action: merge The PR is ready for merge by the caretaker labels Oct 3, 2015
@alexeagle
Copy link
Copy Markdown
Contributor

alexeagle commented Oct 3, 2015

This did not depend on my change, right? I haven't submitted yet because the checkCyclicalDependencies finds cycles in the commonjs dep graph...

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

pkozlowski-opensource commented Oct 3, 2015

@alexeagle nope, this doesn't require your change. I've got few more cleanups in the pipe (ex.: removing dependency on gulp-traceur) for which I'm going to open PRs as soon as your patch lands.

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@IgorMinar IgorMinar

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pkozlowski-opensource @mary-poppins @alexeagle @IgorMinar @googlebot
X Tutup