fix(compiler): const is not supported in IE9 and IE10#4465
Closed
marclaval wants to merge 1 commit intoangular:masterfrom
Closed
fix(compiler): const is not supported in IE9 and IE10#4465marclaval wants to merge 1 commit intoangular:masterfrom
marclaval wants to merge 1 commit intoangular:masterfrom
Conversation
marclaval
force-pushed
the
noConstInIE
branch
2 times, most recently
from
12d68a7 to
1290a2e
Compare
marclaval
added
the
action: review
Contributor
|
Hi Marc, this looks good. |
tbosch
added
pr_state: LGTM
action: cleanup
|
Merging PR #4465 on behalf of @tbosch to branch presubmit-tbosch-pr-4465. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new compiler, 4 unit tests are failing in these browsers.
The reason is that they don't support
const, see https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Instructions/constAs far as I can see, the TS compiler transforms all
constintovar.@tbosch Would it be an issue to do the same in our compiler when targeting JS please?