lgtm, but you need to rebase it against master again.

@alexeagle thnx for this PR, I saw that you've done some changes that I was planning to do as well (dropping traceur related transpilation). I've sent a follow-up PR #4502 to clean up some more stuff.

@alexeagle what happened with this PR? can we get it in? :)

I am stuck on the cyclical dependency problem. I've spent quite a bit of
time trying a few approaches:

• drop the cycle check. But Marc says we still need it, because while CJS
  has some loader shim to make it possible, it can introduce quirky behavior
  that has cost us debugging time in the past
• check for cycles against the TS sources instead of the es6 emit. But
  Madge doesn't work against our TS sources, I've spent a couple hours
  tracking down the cause but haven't gotten it yet
• check for cycles against the es5 emit, but it's broken because we
  actually do have cycles in the module dependency graph, which do not exist
  in the symbol dependency graph. one fix would be
  • fix the module-level cycles. There are two, and one was fixable, but
    the other is hard and Tobias said it should just stay that way.

On Mon, Nov 2, 2015 at 10:29 AM Igor Minar notifications@github.com wrote:

@alexeagle https://github.com/alexeagle what happened with this PR? can
we get it in? :)

—
Reply to this email directly or view it on GitHub
#4454 (comment).

@alexeagle how is circular-dep check related to this PR? we currently run it on the es6 output anyway.

also, have you seen #5022?

It's related because if we remove the es6 output, we have to check for
circular dependencies on some other tree.
I had not seen that bug, but those are the same circular deps I observed. I
suspect you are seeing the same thing I described: these are
module-circular-deps but not symbol-circular-deps.

On Mon, Nov 2, 2015 at 10:34 PM Igor Minar notifications@github.com wrote:

@alexeagle https://github.com/alexeagle how is circular-dep check
related to this PR? we currently run it on the es6 output anyway.

also, have you seen #5022 #5022
?

—
Reply to this email directly or view it on GitHub
#4454 (comment).

Just one remark - many projects don't need to support IE or the Android Browser and such projects in a year may very well work only in ES6-capable browsers without transpilation (Edge already has almost 90% score in the kangax test so this is not a distant future). A pure ES6 build would be useful for such purposes.

People can always compile Angular themselves from TypeScript to ES6 although that's harder.

Closing as we decided to keep ES6 output for now.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}