X Tutup
Skip to content

View factory#4367

Closed
tbosch wants to merge 2 commits intoangular:masterfrom
tbosch:view_factory
Closed

View factory#4367
tbosch wants to merge 2 commits intoangular:masterfrom
tbosch:view_factory

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Sep 25, 2015

No description provided.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: For non components there is nothing to be normalized

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 25, 2015
@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Sep 25, 2015

Reviewed in person with @IgorMinar

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbosch, this was supposed to be named getStylesFromData, right ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for catching.
On Sat, Sep 26, 2015 at 10:00 AM Georgios Kalpakas notifications@github.com
wrote:

In modules/angular2/src/core/compiler/template_commands.ts
#4367 (comment):

@@ -15,6 +15,10 @@ import {
*/
@const()
export class CompiledTemplate {

  • static getChangeDetectorFromData(data: any[]): Function { return data[0]; }
  • static getCommandsFromData(data: any[]): TemplateCmd[] { return data[1]; }
  • static getSylesFromData(data: any[]): string[] { return data[2]; }

@tbosch https://github.com/tbosch, this was suposed to be named
getStylesFromData, right ?


Reply to this email directly or view it on GitHub
https://github.com/angular/angular/pull/4367/files#r40495596.

@tbosch tbosch deleted the view_factory branch October 2, 2015 02:27
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup