I think I just realised that @gkalpak already mentioned most of the typos that I mentioned on the PR. Didn't want to comment just on the comment. Sorry for spamming

Thank you guys for the feedback, PTAL

One change we should make everywhere is to at least in the first sentence always mention both directives and components (even though Component is subclass of Directive) because most users won't realize this connection.

Otherwise this looks quite good!

One change we should make everywhere is to at least in the first sentence always mention both directives and components (even though Component is subclass of Directive) because most users won't realize this connection.

We should have a convention that we use across the code base. Could we handle that a part of an other PR once we have decided ?

@IgorMinar Thanks for the review. Most of your feeback has been implemented, I've added comments otherwise. Please let me know if that's ok.

replied to your comments.

wrt directive/component we can do that in a different pass/pr.

PR updated, PTAL.

I went over all of the first sentences for all of these hooks and I'm proposing the following changes (using code formatting to make visual diffing easier):

# OnChanges
- Implement this interface to get notified when any data-bound property of the directive changes.
+ Implement this interface to get notified when any data-bound property of your directive changes.

# OnInit
- Implement this interface to get notified when the directive or's data-bound properties have been initalized.
+ Implement this interface to execute custom initialization logic after your directive's data-bound properties have been initialized.

# DoCheck
- Implement this interface to override the default change detection algorithm for the directive.
+ Implement this interface to override the default change detection algorithm for your directive.

# OnDestroy
- Implement this interface to get notified when the directive is destroyed.
+ Implement this interface to get notified when your directive is destroyed.

# AfterContentInit
- Implement this interface to get notified when all of the content children have had their data-bound properties initialized.
+ Implement this interface to get notified when your directive's content has been fully initialized.

# AfterContentChecked
- Implement this interface to get notified each time the content children have been checked.
- Implement this interface to get notified after every check of your directive's content.

# AfterViewInit
- Implement this interface to get notified when all of the view children have had their data-bound properties initialized.
+ Implement this interface to get notified when your component's view has been fully initialized.

# AfterViewChecked
- Implement this interface to get notified each time the view children have been checked.
+ Implement this interface to get notified after every check of your component's view.

Sorry for all the back and forth but this api is important.

btw I'm not too happy with the "view" and "content" terminology used here as it's not consistent with the rest of the apis, but let's leave that for another discussion/pr.

Sorry for all the back and forth but this api is important.

No problem I love feedback ;)
Your proposals are valuable, I'll go ahead and implement it.

WRT "view" and "content", I do agree. This is something that we should agree at global level & document.

@IgorMinar As much as I love feedback, I hope you'll be fine with the latest version of this PR.

Thanks for your suggestions, all of them have been implemented

lgmt. go ahead and merge

Merging PR #4357 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4357.

Merging PR #4357 on behalf of @vicb to branch presubmit-vicb-pr-4357.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}