feat(query): implement ContentChildren and ViewChildren#4237
Closed
vsavkin wants to merge 2 commits intoangular:masterfrom
Closed
feat(query): implement ContentChildren and ViewChildren#4237vsavkin wants to merge 2 commits intoangular:masterfrom
vsavkin wants to merge 2 commits intoangular:masterfrom
Conversation
vsavkin
added
action: review
vsavkin
force-pushed
the
query_to_field
branch
from
594306a to
3ac54f4
Compare
Contributor
There was a problem hiding this comment.
did we consider having queries and viewqueries separately?
Contributor
There was a problem hiding this comment.
Nevermind, there is no value is separating them.
Contributor
There was a problem hiding this comment.
Replace Function event with (any, any) => any it will still provide a bit more typechecking, i.e. calling it with wrong number of args.
rkirov
added
pr_state: LGTM
and removed
action: review
vsavkin
force-pushed
the
query_to_field
branch
from
3ac54f4 to
fc1b410
Compare
|
Merging PR #4237 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4237. |
mary-poppins
removed
the
action: merge
vsavkin
force-pushed
the
query_to_field
branch
from
fc1b410 to
b84a84e
Compare
|
Merging PR #4237 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4237. |
mary-poppins
removed
the
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mhever @rkirov Could either of you review this guy?