X Tutup
Skip to content

fix(bug): reflect Dart interfaces from superclass as well #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexeagle wants to merge 1 commit into from
Closed

fix(bug): reflect Dart interfaces from superclass as well #4222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions modules/angular2/src/core/reflection/reflection_capabilities.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,13 @@ class ReflectionCapabilities implements PlatformReflectionCapabilities {
}

List interfaces(type) {
ClassMirror classMirror = reflectType(type);
return classMirror.superinterfaces.map((si) => si.reflectedType).toList();
return _interfacesFromMirror(reflectType(type));
}

List _interfacesFromMirror(classMirror) {
return classMirror.superinterfaces.map((si) => si.reflectedType).toList()
..addAll(classMirror.superclass == null ? []
: _interfacesFromMirror(classMirror.superclass));
}

GetterFn getter(String name) {
Expand Down
8 changes: 6 additions & 2 deletions modules/angular2/test/core/reflection/reflector_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ class TestObj {

class Interface {}

class ClassImplementingInterface implements Interface {}
class Interface2 {}

class SuperClassImplementingInterface implements Interface2 {}

class ClassImplementingInterface extends SuperClassImplementingInterface implements Interface {}

export function main() {
describe('Reflector', () => {
Expand Down Expand Up @@ -191,7 +195,7 @@ export function main() {
describe("interfaces", () => {
it("should return an array of interfaces for a type", () => {
var p = reflector.interfaces(ClassImplementingInterface);
expect(p).toEqual([Interface]);
expect(p).toEqual([Interface, Interface2]);
});

it("should return an empty array otherwise", () => {
Expand Down
X Tutup