X Tutup
Skip to content

fix(code size): do not rely on Uri in BrowserDomAdapter #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yjbanov wants to merge 1 commit into from
Closed

fix(code size): do not rely on Uri in BrowserDomAdapter #4182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions modules/angular2/src/core/dom/browser_adapter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,13 +426,12 @@ class BrowserDomAdapter extends GenericBrowserDomAdapter {
return window.location;
}

getBaseHref() {
String getBaseHref() {
var href = getBaseElementHref();
if (href == null) {
return null;
}
var baseUri = Uri.parse(href);
return baseUri.path[0] == '/' ? baseUri.path : ('/' + baseUri.path);
return _relativePath(href);
}

resetBaseElement() {
Expand Down Expand Up @@ -487,3 +486,14 @@ String getBaseElementHref() {
}
return baseElement.getAttribute('href');
}

// based on urlUtils.js in AngularJS 1
AnchorElement _urlParsingNode = null;
String _relativePath(String url) {
if (_urlParsingNode == null) {
_urlParsingNode = new AnchorElement();
}
_urlParsingNode.href = url;
var pathname = _urlParsingNode.pathname;
return (pathname[0] == '/') ? pathname : '/${pathname}';
}
X Tutup