X Tutup
Skip to content

Replace traceur with es6-shim#4148

Closed
rkirov wants to merge 1 commit intoangular:masterfrom
rkirov:es6-shim
Closed

Replace traceur with es6-shim#4148
rkirov wants to merge 1 commit intoangular:masterfrom
rkirov:es6-shim

Conversation

@rkirov
Copy link
Copy Markdown
Contributor

@rkirov rkirov commented Sep 11, 2015

No description provided.

@rkirov rkirov force-pushed the es6-shim branch 7 times, most recently from f71cd95 to 92b0b95 Compare September 12, 2015 01:43
@rkirov rkirov changed the title WIP: replace traceur with es6-shim Replace traceur with es6-shim Sep 12, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this deep intent is a sign that some expression should be extracted to a local var

@alexeagle
Copy link
Copy Markdown
Contributor

what about traceur-runtime.d.ts? Should we replace it with https://github.com/borisyankov/DefinitelyTyped/blob/master/es6-shim/es6-shim.d.ts ?

@alexeagle
Copy link
Copy Markdown
Contributor

@rkirov says we'll fix the traceur-runtime typings in a later change.

This removes traceur as a dependency for the t push -f
angular2 build.
@rkirov rkirov added the action: merge The PR is ready for merge by the caretaker label Sep 14, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4148 on behalf of @rkirov to branch presubmit-rkirov-pr-4148.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 14, 2015
@rkirov rkirov closed this in cac25fe Sep 14, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup