Travis needs to be restarted once #4097 is merged

FYI @jteplitz602 this PR removes web_worker from the angular2 typings and doesn't create a separate typings file. If you want me to change that I can (I'm not sure if we had already published angular2 with worker typings or not, which would make this a breaking change).

@jeffbcross Looking at DefinitelyTyped I don't think the typings ever made it into a release so that's fine. Once I finish #4064 WebWorkers will have their own typings files anyways.

To recap an IRL conversation with @alexeagle a few days ago when we reviewed this...

• We determined it was best to not introduce a new typings file, generated_typings.d.ts, that would have to be included in our distributions.
• For the InjectableReference typing, we should just define and export it from core.ts, since it has no significant side effects to do so.
• I think we decided to just remap StringMap to Object, even though StringMap is more constrained than Object, and also requires square-bracket accessors instead of dot notation.
• I think for now, we are going to leave the Map declaration hard-coded in the global namespace inside the core.d.ts template, rather than solve issues relating to ES5/ES6 targets in this PR.

@alexeagle is this accurate?

Yes, that matches what I remember.
Note that Rado is removing last bits of traceur so we could revisit the
traceur-runtime.d.ts.

On Mon, Sep 14, 2015 at 12:34 PM Jeff Cross notifications@github.com
wrote:

To recap an IRL conversation with @alexeagle
https://github.com/alexeagle a few days ago when we reviewed this...

• We determined it was best to not introduce a new typings file,
  generated_typings.d.ts, that would have to be included in our
  distributions.
• For the InjectableReference typing, we should just define and export
  it from core.ts, since it has no significant side effects to do so.
• I think we decided to just remap StringMap to Object, even though
  StringMap is more constrained than Object, and also requires
  square-bracket accessors instead of dot notation.
• I think for now, we are going to leave the Map declaration
  hard-coded in the global namespace inside the core.d.ts template,
  rather than solve issues relating to ES5/ES6 targets in this PR.

@alexeagle https://github.com/alexeagle is this accurate?

—
Reply to this email directly or view it on GitHub
#4111 (comment).

I actually decided to keep InjectableReference in the typings template so that it won't show up in our docs.

I also didn't alias StringMap to Object since Object is not generic. I just left it in the core.d.ts file under the ng namespace.

LGTM

Good rationale for leaving those things where they are. We can clean it up a bit more later, maybe after TS 1.6.

@mhevery @tbosch or @vsavkin can one of you review this commit that changes where the public API imports from? jeffbcross@aa838e4

The other way to solve this would be to add all router and http public exports to the test.

Got the verbal LGTM from @mhevery on the updated commit to public_api_spec 42d29e4

Going to verify that the only Travis flakes are related to our current build issues so I can send to presubmit (since the build issue is only present in the PR travis jobs).

I haven't touched this in a couple of weeks, but realize I forgot to comment on the status. I ran into issues with a handful of router exports not being correctly re-exported from angular2/angular2 when checking in the public API spec. Also, our typings process is simplifying, leaving much of this PR blissfully obsolete.

After chatting with @IgorMinar this morning, neither of us are super keen on distributing http and router as part of the angular2 bundle.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}