X Tutup
Skip to content

Update Rx#4058

Closed
vsavkin wants to merge 5 commits intoangular:masterfrom
vsavkin:update_rx_to_rx_next
Closed

Update Rx#4058
vsavkin wants to merge 5 commits intoangular:masterfrom
vsavkin:update_rx_to_rx_next

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Sep 8, 2015

No description provided.

@PatrickJS
Copy link
Copy Markdown
Contributor

PatrickJS commented Sep 8, 2015

👍

@PatrickJS PatrickJS mentioned this pull request Sep 8, 2015
Closed
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 6479001 to 2929fe3 Compare September 8, 2015 23:38
@vsavkin vsavkin changed the title Update RX WIP Update R Sep 8, 2015
@vsavkin vsavkin changed the title Update R Update Rx Sep 8, 2015
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 2929fe3 to 1f8432c Compare September 8, 2015 23:47
@vsavkin vsavkin added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Sep 8, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 8, 2015

Merging PR #4058 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4058.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 8, 2015
@vsavkin
Copy link
Copy Markdown
Contributor Author

vsavkin commented Sep 8, 2015

Pair with Jeff on this. He LGTMed it.

@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch 2 times, most recently from 673bb22 to 5eb44fb Compare September 9, 2015 23:11
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 9, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 9, 2015

Merging PR #4058 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4058.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 9, 2015
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 5eb44fb to 57a874b Compare September 10, 2015 18:35
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 10, 2015

Merging PR #4058 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4058.

@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 10, 2015
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch 3 times, most recently from 3742a5e to 8b3799d Compare September 11, 2015 22:38
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 11, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 11, 2015

Merging PR #4058 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4058.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 11, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Sep 11, 2015

@vsavkin you might need to rebase

@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 8b3799d to 625f5ab Compare September 11, 2015 23:48
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 11, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 11, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 11, 2015

Merging PR #4058 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4058.

@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 625f5ab to 2e14683 Compare September 13, 2015 21:43
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 13, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 13, 2015

Merging PR #4058 on behalf of @vsavkin to branch presubmit-vsavkin-pr-4058.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 13, 2015
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 2e14683 to 1589006 Compare September 14, 2015 21:30
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 5b87801 to b64fbc6 Compare September 15, 2015 17:23
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch 3 times, most recently from 738531e to 2b35ac9 Compare September 15, 2015 21:12
@vsavkin vsavkin force-pushed the update_rx_to_rx_next branch from 2b35ac9 to 07c2d7a Compare September 15, 2015 21:26
@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Sep 15, 2015

Sorry, no good. Closing in favor of #4201.

@jeffbcross jeffbcross closed this Sep 15, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vsavkin @PatrickJS @mary-poppins @jeffbcross @googlebot
X Tutup