X Tutup
Skip to content

Revert "fix(core): fix possible XSS attack in development through SSR (#40525)#40533

Closed
jessicajaniuk wants to merge 1 commit intoangular:masterfrom
jessicajaniuk:revert_40525
Closed

Revert "fix(core): fix possible XSS attack in development through SSR (#40525)#40533
jessicajaniuk wants to merge 1 commit intoangular:masterfrom
jessicajaniuk:revert_40525

Conversation

@jessicajaniuk
Copy link
Contributor

@jessicajaniuk jessicajaniuk commented Jan 23, 2021

This reverts commit bb3b315.

Reason for Revert: Issues with Google3 TAP Failures

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@thePunderWoman
Revert "fix(core): fix possible XSS attack in development through SSR (…
d647d10 
…angular#40525)"

This reverts commit bb3b315.

Reason for Revert: Issues with Google3 TAP Failures
@google-cla google-cla bot added the cla: yes label Jan 23, 2021
@jessicajaniuk jessicajaniuk added the target: patch This PR is targeted for the next patch release label Jan 23, 2021
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: security Issues related to built-in security features, such as HTML sanitation labels Jan 23, 2021
@ngbot ngbot bot modified the milestone: Backlog Jan 23, 2021
jessicajaniuk pushed a commit that referenced this pull request Jan 23, 2021
@thePunderWoman
Revert "fix(core): fix possible XSS attack in development through SSR (…
761b8fe 
…#40525)" (#40533)

This reverts commit bb3b315.

Reason for Revert: Issues with Google3 TAP Failures

PR Close #40533
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 23, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 23, 2021
@jessicajaniuk jessicajaniuk deleted the revert_40525 branch October 26, 2021 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: security Issues related to built-in security features, such as HTML sanitation cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@jessicajaniuk @AndrewKushnir @thePunderWoman
X Tutup