X Tutup
Skip to content

feat(core): add support for @HostProperty and @HostListener#3996

Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:use_host_prop_and_host_listener_decorators
Closed

feat(core): add support for @HostProperty and @HostListener#3996
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:use_host_prop_and_host_listener_decorators

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Sep 4, 2015

Example:

@Directive({selector: 'my-directive'})
class MyDirective {
  @HostProperty("attr.my-attr") myAttr: string;
  @HostListener("click", ["$event.target"])
  onClick(target) {
    this.target = target;
  }
}

mhevery
mhevery reviewed Sep 4, 2015
View reviewed changes
modules/angular2/src/core/metadata/directives.ts Outdated
Copy link
Copy Markdown
Contributor

@mhevery mhevery Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put some text that this is equivalent to the Directive.host syntax.

@mhevery mhevery added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 4, 2015
@vsavkin vsavkin force-pushed the use_host_prop_and_host_listener_decorators branch from 4f30aef to fe198fb Compare September 4, 2015 21:03
@vsavkin
feat(core): add support for @HostBinding and @HostListener
6526105 
Example:

@directive({selector: 'my-directive'})
class MyDirective {
  @HostBinding("attr.my-attr") myAttr: string;
  @HostListener("click", ["$event.target"])
  onClick(target) {
    this.target = target;
  }
}
@vsavkin vsavkin force-pushed the use_host_prop_and_host_listener_decorators branch from fe198fb to 6526105 Compare September 4, 2015 21:07
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 4, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 4, 2015

Merging PR #3996 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3996.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 4, 2015
@vsavkin vsavkin closed this in df8e15c Sep 4, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsavkin @mary-poppins @mhevery @googlebot
X Tutup