X Tutup
Skip to content

feat(core): add support for @Property and @Event decorators#3992

Closed
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:core_props_and_events_decorators
Closed

feat(core): add support for @Property and @Event decorators#3992
vsavkin wants to merge 1 commit intoangular:masterfrom
vsavkin:core_props_and_events_decorators

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Sep 4, 2015

Example:

@Directive({selector: 'my-selector'})
class MyDirective {
  @Property() prop;
  @Property('el-prop') prop2;
  @Event() event;
  @Event('el-event') event2;
}

@vsavkin
feat(core): add support for @Property and @event decorators
c46427f 
Example:

@directive({selector: 'my-selector'})
class MyDirective {
  @Property() prop;
  @Property('el-prop') prop2;
  @event() event;
  @event('el-event') event2;
}
@vsavkin vsavkin added comp: core effort2: days action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 4, 2015
@vsavkin vsavkin added this to the alpha-38 milestone Sep 4, 2015
@PatrickJS
Copy link
Copy Markdown
Contributor

PatrickJS commented Sep 4, 2015

can we also get an Observable event?
@ObservableEvent('mouseover') mouseover;

update: nvm I see it's possible
@Event('elEvent') event = new EventEmitter();

@mhevery mhevery added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 4, 2015
@mhevery mhevery assigned vsavkin and unassigned mhevery Sep 4, 2015
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Sep 4, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 4, 2015

Merging PR #3992 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3992.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 4, 2015
@vsavkin vsavkin closed this in 896add7 Sep 4, 2015
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Sep 4, 2015

Yeeeeeesssssss!!! Thnx @mhevery @vsavkin

@0x-r4bbit
Copy link
Copy Markdown
Contributor

0x-r4bbit commented Sep 5, 2015

This is really syntactic sugar right? We will still be able to use properties: [] and EventEmitter constructor?

@thelgevold
Copy link
Copy Markdown
Contributor

thelgevold commented Sep 7, 2015

I like this idea and think it's an improvement over the current properties:[] syntax. Seems more clear to me.

@0x-r4bbit
Copy link
Copy Markdown
Contributor

0x-r4bbit commented Sep 7, 2015

@thelgevold yes, but if you'd write that in ES5, creating an annotation by hand everytime you wanna add a property is kinda huge.

@thelgevold
Copy link
Copy Markdown
Contributor

thelgevold commented Sep 7, 2015

@PascalPrecht Yes, I think that is a good point. I am guessing they will still support the current properties:[] along side this new idea. Probably just a new short notation like you pointed out above.

@robwormald robwormald mentioned this pull request Sep 8, 2015
Closed
@gionkunz
Copy link
Copy Markdown
Contributor

gionkunz commented Sep 11, 2015

Simply awesome guys! 👍

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

cla: yes effort2: days

Projects

None yet

Milestone

alpha-38

Development

Successfully merging this pull request may close these issues.

9 participants

@vsavkin @PatrickJS @mary-poppins @pkozlowski-opensource @0x-r4bbit @thelgevold @gionkunz @mhevery @googlebot
X Tutup