X Tutup
Skip to content

WIP: exports changes.#3977

Closed
jeffbcross wants to merge 4 commits intoangular:masterfrom
jeffbcross:exports
Closed

WIP: exports changes.#3977
jeffbcross wants to merge 4 commits intoangular:masterfrom
jeffbcross:exports

Conversation

@jeffbcross
Copy link
Copy Markdown
Contributor

@jeffbcross jeffbcross commented Sep 3, 2015

No description provided.

@jeffbcross jeffbcross added state: WIP area: build & ci Related the build and CI infrastructure of the project refactoring Issue that involves refactoring or code-cleanup labels Sep 3, 2015
@jeffbcross jeffbcross self-assigned this Sep 3, 2015
@jeffbcross jeffbcross added this to the alpha-37 milestone Sep 3, 2015
@jeffbcross jeffbcross force-pushed the exports branch 12 times, most recently from d94dba3 to 2da5237 Compare September 4, 2015 22:45
@jeffbcross jeffbcross added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed state: WIP labels Sep 4, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor Author

jeffbcross commented Sep 4, 2015

Got verbal LGTM from @IgorMinar with some cleanup todos.

@jeffbcross jeffbcross force-pushed the exports branch 2 times, most recently from c7728a7 to 2dc17e9 Compare September 4, 2015 23:26
@jeffbcross jeffbcross force-pushed the exports branch 2 times, most recently from 1496f89 to c5333a4 Compare September 5, 2015 06:13
@jeffbcross
refactor: export core APIs from angular2/core
7804523 
This change moves many APIs to the angular2/core export.

This change also automatically adds FORM_BINDINGS in
the application root injector.

BREAKING CHANGE:
    Many dependencies that were previously exported from specific
    APIs are now exported from angular2/core. Affected exports, which
    should now be included from angular2/core include:

    angular2/forms
    angular2/di
    angular2/directives
    angular2/change_detection
    angular2/bootstrap (except for dart users)
    angular2/render
    angular2/metadata
    angular2/debug
    angular2/pipes
@jeffbcross jeffbcross added the action: merge The PR is ready for merge by the caretaker label Sep 5, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 5, 2015

Merging PR #3977 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-3977.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 5, 2015
@jeffbcross jeffbcross closed this in f14b212 Sep 5, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jeffbcross jeffbcross

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: build & ci Related the build and CI infrastructure of the project cla: yes refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Milestone

alpha-37

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffbcross @mary-poppins @googlebot
X Tutup