fix(WebWorker): Fix Todo Server demo and add test to ensure the demo can bootstrap.#3970
Closed
jteplitz wants to merge 1 commit intoangular:masterfrom
Closed
fix(WebWorker): Fix Todo Server demo and add test to ensure the demo can bootstrap.#3970jteplitz wants to merge 1 commit intoangular:masterfrom
jteplitz wants to merge 1 commit intoangular:masterfrom
Conversation
jteplitz
added
action: review
Contributor
There was a problem hiding this comment.
Since the controller is assigned once, it can be made final, and as a bonus, you can also omit the LHS type annotation, since it is inferred from the RHS.
yjbanov
added
pr_state: LGTM
action: cleanup
jteplitz
force-pushed
the
server-message-bus
branch
2 times, most recently
from
9f32a77 to
7830aa7
Compare
jteplitz
removed
the
action: cleanup
jteplitz
force-pushed
the
server-message-bus
branch
from
7830aa7 to
8579997
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3348