fix(Typings): Output public constructors in .d.ts files#3963
Closed
jteplitz wants to merge 1 commit intoangular:masterfrom
Closed
fix(Typings): Output public constructors in .d.ts files#3963jteplitz wants to merge 1 commit intoangular:masterfrom
jteplitz wants to merge 1 commit intoangular:masterfrom
Conversation
jteplitz
added
comp: docs
action: review
jteplitz
force-pushed
the
docs
branch
2 times, most recently
from
518b690 to
13b0892
Compare
jteplitz
added
state: WIP
and removed
action: review
jteplitz
added
action: review
jteplitz
force-pushed
the
docs
branch
3 times, most recently
from
0eade5d to
cd9a1c2
Compare
modules/angular2/render.ts
Outdated
Contributor
There was a problem hiding this comment.
What is being filtered out here?
Contributor
|
Looks good once you change the export at |
jeffbcross
added
pr_state: LGTM
action: cleanup
jeffbcross
removed
the
action: review
jteplitz
removed
the
action: cleanup
nponiros
added a commit
to jsperts/presentations
that referenced
this pull request
Sep 10, 2015
Workaround an issue with the angular typings by exiting with 0 always. Currently the typings do not contain public constructors which results in an error during compilation as the compiler does not know the arguments expected by the Control constructor. See issue angular/angular#3938 Pull request angular/angular#3963
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3926.