Closed
Conversation
vsavkin
added
feature
Contributor
There was a problem hiding this comment.
normalize to False instead of just being falsy (undefined/null) in case it is not provided?
Contributor
There was a problem hiding this comment.
nevermind, const-ness prevents that.
vsavkin
force-pushed
the
di_multibindings
branch
from
869345c to
e734fcf
Compare
|
Merging PR #3962 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3962. |
BREAKING CHANGE Previously a content binding of a component was visible to the directives in its view with the host constraint. This is not the case any more. To access that binding, remove the constraint.
…validators BREAKING CHANGE Before: @directive({selector: '[credit-card]', bindings: [new Binding(NgValidator, {toAlias: forwardRef(() => CreditCardValidator)})]}) class CreditCardValidator { get validator() { return CreditCardValidator.validate; } static validate(c): StringMap<string, boolean> {...} } After: function creditCardValidator(c): StringMap<string, boolean> {...} @directive({selector: '[credit-card]', bindings: [new Binding(NG_VALIDATORS, {toValue: creditCardValidator, multi: true})]}) class CreditCardValidator {}
vsavkin
force-pushed
the
di_multibindings
branch
from
e734fcf to
9d0a69d
Compare
|
Merging PR #3962 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3962. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.