fix(query): clean-up queryref during dehydration#3948
Closed
rkirov wants to merge 1 commit intoangular:masterfrom
Closed
fix(query): clean-up queryref during dehydration#3948rkirov wants to merge 1 commit intoangular:masterfrom
rkirov wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
@tbosch any ideas how to make this more useful?
rkirov
force-pushed
the
dehydrate_query
branch
2 times, most recently
from
0316e9a to
c0388a6
Compare
rkirov
force-pushed
the
dehydrate_query
branch
from
c0388a6 to
9384a8f
Compare
The QueryRef objects persists during dehydration but needs to be cleaned-up by removing callbacks and previous elements. Closes angular#3944
rkirov
force-pushed
the
dehydrate_query
branch
from
9384a8f to
d699297
Compare
|
Merging PR #3948 on behalf of @rkirov to branch presubmit-rkirov-pr-3948. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QueryRef objects persists during dehydration but needs to be
cleaned-up by removing callbacks and previous elements.
Closes #3944