X Tutup
Skip to content

Small fixes while updating to TS 1.6#3865

Closed
mhegazy wants to merge 16 commits intoangular:masterfrom
mhegazy:updateToTS1.6
Closed

Small fixes while updating to TS 1.6#3865
mhegazy wants to merge 16 commits intoangular:masterfrom
mhegazy:updateToTS1.6

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented Aug 27, 2015

Trying TS1.6 on latest from master and ran into a few compiler errors. here are the fixes. This should work just fine for 1.5, but would make migrating to 1.6 error-free.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Aug 28, 2015

Looks like your changes broke dart. https://travis-ci.org/angular/angular/jobs/77609361#L718 Could you have a look?

@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Aug 28, 2015

yes. my bad. did not think i needed to run the dart checks.. sorry about that.

Conflicts:
	modules/angular2/src/core/render/dom/view/proto_view_builder.ts
	modules/angular2/src/http/url_search_params.ts
@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Sep 1, 2015

@mhevery what is the easiest way to get Dart SDK installed on a Windows machine, i got the package downloaded, but it is a .zip file. and the failing tasks only run if dart sdk is installed.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Sep 1, 2015

@Mlaval can you help @mhegazy with the windows dart installation question. Can we better document this here: https://github.com/angular/angular/blob/master/DEVELOPER.md

@marclaval
Copy link
Copy Markdown
Contributor

@mhegazy what works for me is to first download Dart SDK and Dartium from https://www.dartlang.org/downloads/archive/ and unzip them somewhere.
Then, I edit the environment variable as follows:

  1. Add Dart to the Path, e.g. D:\Dev\Dart\dart-sdk\bin
  2. Create a new env variable named DARTIUM_BIN which points to the Dartium exe, e.g. D:\Dev\Dart\dartium-win-full-stable-1.12.0.0\chrome.exe

@mhevery I'll do an update

@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Sep 1, 2015

thanks @Mlaval and @mhevery. looks like the dart issue has been resolved with my latest changes.

marclaval added a commit that referenced this pull request Sep 11, 2015
@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 11, 2015
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Sep 11, 2015

Could you rebase ontop of master?

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Sep 28, 2015

Thanks, we are already on 1.6.

@tbosch tbosch closed this Sep 28, 2015
@mhegazy mhegazy deleted the updateToTS1.6 branch September 29, 2015 16:30
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup