Small fixes while updating to TS 1.6#3865
Conversation
…lass and property decorator
|
Looks like your changes broke dart. https://travis-ci.org/angular/angular/jobs/77609361#L718 Could you have a look? |
|
yes. my bad. did not think i needed to run the dart checks.. sorry about that. |
…uld be done in the TS compiler
Conflicts: modules/angular2/src/core/render/dom/view/proto_view_builder.ts modules/angular2/src/http/url_search_params.ts
|
@mhevery what is the easiest way to get Dart SDK installed on a Windows machine, i got the package downloaded, but it is a .zip file. and the failing tasks only run if dart sdk is installed. |
|
@Mlaval can you help @mhegazy with the windows dart installation question. Can we better document this here: https://github.com/angular/angular/blob/master/DEVELOPER.md |
|
@mhegazy what works for me is to first download Dart SDK and Dartium from https://www.dartlang.org/downloads/archive/ and unzip them somewhere.
@mhevery I'll do an update |
|
Could you rebase ontop of master? |
This reverts commit 65e34c0. Conflicts: modules/angular2/src/router/router_outlet.ts
|
Thanks, we are already on 1.6. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Trying TS1.6 on latest from master and ran into a few compiler errors. here are the fixes. This should work just fine for 1.5, but would make migrating to 1.6 error-free.