feat(core): remove the (^ syntax and make all DOM events bubbling#3864
feat(core): remove the (^ syntax and make all DOM events bubbling#3864vsavkin wants to merge 1 commit intoangular:masterfrom
Conversation
vsavkin
added
comp: core
action: review
|
Yes! Out of curiosity - what were the trade-offs here? I mean, why we've decided to not catch bubbling events by default? |
|
@pkozlowski-opensource The change is that event decides if it is bubbling or not. In practice it turns out that you want all user events (mouse, keys, etc) to bubble, but non of the app events (open,close,onChange, etc) to bubble. So we are going the route of event declaring if it wants to bubble or not. |
|
Related: #2296 |
mhevery
added
pr_state: LGTM
and removed
action: review
There was a problem hiding this comment.
Hammer events do not bubble by default - because they are not using DOM events.
It is possible to configure Hammer events to bubble (by using DOM event, it comes with a perf penalty) ? This could peobably be done in a follow up PR.
|
Will custom events bubble up by default too then? |
|
@PascalPrecht custom dom events can bubble, but synthetic events won't. |
vsavkin
force-pushed
the
remove_bubbling
branch
from
72b9f9e to
2264766
Compare
|
Merging PR #3864 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3864. |
mary-poppins
removed
the
action: merge
BREAKING CHANGE Before <div (^click)="onEventHandler()"> <button></button> </div> After <div (click)="onEventHandler()"> <button></button> </div>
vsavkin
force-pushed
the
remove_bubbling
branch
from
2264766 to
d2f74d0
Compare
|
Merging PR #3864 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3864. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
7 participants
BREAKING CHANGE
Before
After