X Tutup
Skip to content

chore(http): remove unused properties from Request#3823

Closed
0x-r4bbit wants to merge 1 commit intoangular:masterfrom
0x-r4bbit:refactor-http
Closed

chore(http): remove unused properties from Request#3823
0x-r4bbit wants to merge 1 commit intoangular:masterfrom
0x-r4bbit:refactor-http

Conversation

@0x-r4bbit
Copy link
Copy Markdown
Contributor

This removes properties mentioned in #3339

Closes #3339

@0x-r4bbit
Copy link
Copy Markdown
Contributor Author

@jeffbcross couldn't find those properties in Response though

@0x-r4bbit 0x-r4bbit mentioned this pull request Aug 31, 2015
35 tasks
@jeffbcross
Copy link
Copy Markdown
Contributor

@PascalPrecht lookin' good! The properties should also be removed in base_request_options.

Don't worry about Response. It has some properties that aren't yet being used by XHRBackend, but they are more straightforward than these properties on Request.

Looks like you'll need to rebase against master before pushing again.

@0x-r4bbit
Copy link
Copy Markdown
Contributor Author

@jeffbcross done.

@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 11, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor

@PascalPrecht sorry for dragging my feet on this! I fixed the formatting issue, and removed some enums/interfaces. Pushed to presubmit so hopefully it gets merged to master without issue! https://github.com/angular/angular/tree/presubmit-jeffbcross-pr-3823

@0x-r4bbit
Copy link
Copy Markdown
Contributor Author

@jeffbcross I think I can forgive you one last time, my friend.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(http): remove unused properties from Request and Response

5 participants

X Tutup