chore(build): remove references to e6-module-loader#3752
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Closed
chore(build): remove references to e6-module-loader#3752pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
pkozlowski-opensource
force-pushed
the
drop_es6_module_loader
branch
from
38f0e22 to
ec8ff2e
Compare
pkozlowski-opensource
force-pushed
the
drop_es6_module_loader
branch
from
ec8ff2e to
61e8c33
Compare
I believe that it is no longer necessery after migration to a newer version of SystemJS
Member
Author
|
OK, so the TravisCI is green - this plus some manual testing confirms that we don't need e6-module-loader with a new SystemJS loader. I will update the PR with removal of e6-module-loader from package.json but this one can be merged on its own as well. |
pkozlowski-opensource
added
the
action: review
mhevery
added
pr_state: LGTM
and removed
action: review
pkozlowski-opensource
added
the
action: merge
|
Merging PR #3752 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-3752. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that it is no longer necessery after migration
to a newer version of SystemJS done in e68c978
I'm on Linux atm so can't change package / shrinkwrap, but will push an update as soon as TravisCI gets green and I'm on Mac at home.