fix(parser): detect and report interpolation in expressions#3750
fix(parser): detect and report interpolation in expressions#3750pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
There was a problem hiding this comment.
What about adding the check in parseInterpolation() to avoid duplicating the logic here ?
(you would have to check that you are parsing a template binding there)
There was a problem hiding this comment.
Hmm, yeh, this line here is not ideal but I didn't want to call the entire parseIntorpolation just to do this check. I'm not sure I can think of a much better solution atm....
There was a problem hiding this comment.
What I mean is that if parseInterpolation() finds an interpolation while we are parsing a tpl binding, we should throw.
This would also makes your code consistent with the existing code (check how parsePipe() throws when parsing an action)
There was a problem hiding this comment.
LGTM when the minor fixes are in (as discussed)
|
Ah, love this! 👍 |
pkozlowski-opensource
force-pushed
the
interp_in_exps
branch
from
9ff3cb4 to
9675fd4
Compare
pkozlowski-opensource
added
the
action: review
|
@vicb When you say LGTM, please add |
mhevery
added
pr_state: LGTM
action: cleanup
|
All the cleanup was done, going to get ahead and merge it. |
pkozlowski-opensource
added
action: merge
|
Merging PR #3750 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-3750. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
Fixes #3645