X Tutup
Skip to content

Added experimental support for ON_PUSH detectors#3684

Closed
vsavkin wants to merge 2 commits intoangular:masterfrom
vsavkin:on_push_detectors
Closed

Added experimental support for ON_PUSH detectors#3684
vsavkin wants to merge 2 commits intoangular:masterfrom
vsavkin:on_push_detectors

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Aug 17, 2015

No description provided.

@vsavkin vsavkin added this to the alpha-36 milestone Aug 17, 2015
@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 17, 2015
@vsavkin vsavkin force-pushed the on_push_detectors branch from 576788b to f7e4d28 Compare August 17, 2015 22:33
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset to null as well

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Aug 17, 2015

Add basic intergration tests

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Aug 17, 2015

Remove url_params_to_form.js

@tbosch tbosch added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 17, 2015
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Aug 17, 2015

Create one e2e test and exclude it for JS via https://github.com/angular/angular/blob/master/protractor-js.conf.js

@vsavkin vsavkin force-pushed the on_push_detectors branch from f7e4d28 to 7ab5783 Compare August 18, 2015 17:58
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Aug 18, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 18, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #3684 on behalf of @vsavkin to branch presubmit-vsavkin-pr-3684.

@vsavkin vsavkin closed this in 52da220 Aug 18, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup