fix(router): fix regression with generating links to async routes#3650
Closed
fix(router): fix regression with generating links to async routes#3650
Conversation
Contributor
Author
|
And in general, I think this reveals poor test coverage for all the possible different scenarios related to async routes. Once #3335 is resolved, I'd like to spend some time improving the test coverage and code quality in this area. |
Contributor
Author
|
The internal test in question didn't go green, but the error it's throwing is now unrelated to routing. Yay (kind of)~! I pushed this to presubmit in as advised by @IgorMinar. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm labelling this P0 because @IgorMinar and I suspect it's currently blocking sync.
I got Igor's blessings on the code itself in person, but we're still not sure if this resolves the sync issue. If Igor confirms this resolves sync, this should be ready to merge. If it doesn't resolve sync, we can deescalate this, but it's still a legit issue.