Conversation
jeffbcross
added
comp: build/pipeline
action: review
|
I need to fix one thing in the publish script, which is copying over "index.js" from http. |
|
I fixed issues with copying over index*, package.json, and pubspec.yaml into the angular2 distribution. Still need to test installing and using http on a sample project. |
|
I'm going to remove 406a4c4 from this PR and not block the release on that one, since it will require more work to make module paths play well with residing in a different context. I.e. the |
|
Alright, PR reduced to bundles and typings. |
scripts/publish/npm_publish.sh
Outdated
There was a problem hiding this comment.
Could probably remove the first three builds here since they are also called by bundles.js.
|
Reviewed with @alexeagle and he gave verbal LGTM after I make changes we discussed. |
jeffbcross
added
pr_state: LGTM
action: cleanup
The same bundles that are published to https://code.angularjs.org are now included in a "bundles" folder inside the npm distribution. Closes angular#3555
This makes it simple to run the `tsd link` command in a project to automatically include paths to typings files. The definitions also include transitive dependencies of rx.d.ts and es6-promise.d.ts. Closes angular#3590
|
User @jeffbcross does not have PR merging privlidges. |
mary-poppins
removed
the
action: merge
There was a problem hiding this comment.
Nit: call this DTS_FILES_GLOB? Or just inline it? It's rather unlikely to change, ever.
4 participants
I still want to do some manual testing and output comparisons locally, so please don't auto-submit. I'll add a comment once I've finished those.